Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: To fix issues in Boolean editor
Date: 2017-11-16 16:33:17
Message-ID: CA+OCxoyL6eSjL6Ys78Q=u1zJduyZnA=hw1GjH8T67VkLvc3MUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Nov 16, 2017 at 4:30 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> On Thu, Nov 16, 2017 at 8:59 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thu, Nov 16, 2017 at 2:04 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the issue in boolean editor & also corrected feature
>>> test.
>>> RM#2848
>>>
>>
>> Testing in webkit on Mac (Qt 5.8), the problem does not appear to be
>> solved for me. I have run make bundle, and restarted the runtime multiple
>> times.
>>
> ​I tested in Chrome and it was working as expected, Have you tested patch
> with browser?​
>
>

It works fine in Chrome... but then, it was never broken there for me!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2017-11-17 03:48:19 Re: Next release
Previous Message Murtuza Zabuawala 2017-11-16 16:30:01 Re: [pgAdmin4][Patch]: To fix issues in Boolean editor