| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org>, Syed Fahar Abbas <fahar(dot)abbas(at)enterprisedb(dot)com> |
| Subject: | Re: RM4939 - Running in the container as non-root user |
| Date: | 2019-12-04 10:53:23 |
| Message-ID: | CA+OCxoyL3=D4v6hnGnoAjnz+xJoOzxFiCGw0VaZW+36Wk3N8AQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks!
On Wed, Dec 4, 2019 at 4:16 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Dave
>
> I have reviewed the code and tested the basic scenario. The code looks
> good to me. I have verified that the user is pgadmin with user id 5050.
>
> With your patch Without applying
> your patch
> [image: NonRootUser.png] [image: RootUser.png]
>
> @Fahar please test upgrades mostly when using mapped storage or session
> data.
>
> On Wed, Dec 4, 2019 at 8:21 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> The attached patch fixes $SUBJECT. I'm a little concerned about upgrades
>> though, mostly when using mapped storage or session data. Fahar, can you
>> test such scenarios please?
>>
>> Patch review is also needed please :-)
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2019-12-04 12:29:56 | Re: [pgAdmin4] Fix context menu CSS |
| Previous Message | Dave Page | 2019-12-04 10:52:11 | Re: [pgAdmin4] Fix context menu CSS |