From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Matthew Kleiman <mkleiman(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgaweb][patch] Use https link for git repo |
Date: | 2017-08-29 15:09:15 |
Message-ID: | CA+OCxoyL-E3=W9p+esUDcWSYJ3yJdfR0CgZB0X_zQxA+CzT5og@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Tue, Aug 29, 2017 at 3:55 PM, Magnus Hagander <magnus(at)hagander(dot)net>
wrote:
>
>
> On Tue, Aug 29, 2017 at 4:45 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Tue, Aug 29, 2017 at 3:30 PM, Matthew Kleiman <mkleiman(at)pivotal(dot)io>
>> wrote:
>>
>>> bump.
>>>
>>> On Tue, Aug 15, 2017 at 3:58 AM Matthew Kleiman <mkleiman(at)pivotal(dot)io>
>>> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> As per discussion on https://www.postgresql.org/
>>>> message-id/flat/CAGRPzo-_dSYr5Y1D%2B0uBLo39Bb6MVTg3%3DCM%3Dh
>>>> rmX7LdF%3DfQbhQ%40mail.gmail.com#CAGRPzo-_dSYr5Y1D+0uBLo39B
>>>> b6MVTg3=CM=hrmX7LdF=fQbhQ(at)mail(dot)gmail(dot)com, I've updated the pgadmin
>>>> website with the attached patch. Instead of the docs pointing developers to
>>>> an ssh repo link, it points them to https.
>>>>
>>>>
>> Hi
>>
>> I prefer to keep it as git:// - I've seen caching weirdness with http(s)
>> in the past.
>>
>
> Those weirdnesses *should* all be gone if it uses the smart http mode,
> which we didn't support until a few weeks ago, but do now.
>
>
>
>> git:// is supported, and per the thread, Magnus did fix the issue seen.
>> Is there any other reason to change it?
>>
>>
> Security? In particular, MITM:ing initial connections etc.
>
Good point.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Navnath Gadakh | 2017-08-30 05:34:56 | pgAdmin4: Cleanup in role dependency test cases |
Previous Message | Chethana Kumar | 2017-08-29 14:57:10 | Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard |