From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Atul Sharma <atul(dot)sharma(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch][RM_1918] : Implement the DB restriction field from pgAdmin III |
Date: | 2017-07-21 11:49:59 |
Message-ID: | CA+OCxoyKPthz7hYLLG29SZqM6NbaprvGGsRu3M2LZt0pi_GXpw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied!
A couple of tips for the future:
- Please ensure screenshots are of a comparable size to the ones around
them or that they replace. We sometimes see extra-large screenshots where
they've been taken on hi-res screens, often in an VM.
- Please be more generous with spaces, e.g.
func_name(a,b) should be func_name(a, b)
or
if (dave.isHungry()){
dave.feed('Sammich')
}
should be
if (dave.isHungry()) {
dave.feed('Sammich')
}
It makes it all a little more readable :-)
Thanks again.
On Fri, Jul 21, 2017 at 11:01 AM, Atul Sharma <atul(dot)sharma(at)enterprisedb(dot)com>
wrote:
> Hi,
>
> Please find attached patch for RM#1918 : Implement the DB restriction
> field from pgAdmin III
>
> Thanks,
> Atul
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | pgAdmin 4 Jenkins | 2017-07-21 12:09:57 | Build failed in Jenkins: pgadmin4-master-python34 #249 |
Previous Message | Dave Page | 2017-07-21 11:45:01 | pgAdmin 4 commit: Add a field to the Server Dialogue allowing users to |