Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website
Date: 2020-08-25 13:38:52
Message-ID: CA+OCxoyKCp-uvuOVi7ZKvhjAAaqVqRu6YiSZpZ0mDvrFctaQiQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Tue, Aug 25, 2020 at 12:49 PM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:

>
> PFA v5 patch for the same.
>
> if required any updates in this please let me know.
>

Hmm, yeah - that doesn't work for me I'm afraid; it's mixing content with
code.

The titles should be defined in the HTML pages themselves. We do that
everywhere else by including a template block like the following in the
lowest level content:

{% block title %}Contributing{% endblock %}

And then in base.html:

<title>{% block title %}{% endblock %}</title>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Romulo Rodriguez 2020-08-25 14:00:20 Re: LDAP auth pathc
Previous Message Akshay Joshi 2020-08-25 12:47:01 Re: [pgAdmin][SonarQube] Cognitive complexity