Re: Require suggestion for issue #8007

On Tue, 8 Oct 2024 at 16:30, Pravesh Sharma <pravesh(dot)sharma(at)enterprisedb(dot)com>
wrote:

> Hi Dave,
>
> On Tue, Oct 8, 2024 at 6:34 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Tue, 8 Oct 2024 at 13:56, Pravesh Sharma <
>> pravesh(dot)sharma(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> We have been working on issue #8007
>>> <https://github.com/pgadmin-org/pgadmin4/issues/8007>. After our
>>> analysis, we found that the length and scale of the argument's data type
>>> are not stored in the database server, making it difficult to fetch. In the
>>> debugger, pgAdmin typecasts the provided value to its data type when
>>> calling the function, which is causing the issue.
>>>
>>> If we typecast the value to a character without specifying the length,
>>> it is treated as a character (1) (character of length 1). For example, the
>>> output of SELECT 'pgadmin', 'pgadmin'::character; is different.
>>>
>>> There are two solutions we can consider:
>>>
>>> 1. Do not typecast if the data type is character.
>>> 2. Typecast to varchar when the data type is character.
>>>
>>> Please provide your suggestions which solution looks good to you.
>>>
>>
>> Why not include the length in the cast? We know what the input string is,
>> so can't we just do the equivalent of:
>>
>> 'pgadmin'::character(7);
>>
> Just to confirm, this will be only for the character data type?
>

Yes, if that's the only type with which the issue is seen.

--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com