Re: pgAdmin4.cpp - sync missing

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Vladimir Koković <vladimir(dot)kokovic(at)gmail(dot)com>
Cc: "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin4.cpp - sync missing
Date: 2016-04-16 23:01:58
Message-ID: CA+OCxoyEhhsJTzQbyucs_KEHWJTXf9n=9rGt-TsxB5GA1T6Ohw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Saturday, April 16, 2016, Vladimir Koković <vladimir(dot)kokovic(at)gmail(dot)com>
wrote:

> Hi,
>
> settings.sync() missing after the line 110
>

Thanks - in theory it shouldn't be needed as it'll be called in the
destructor and periodically in the event loop, but it doesn't hurt to save
anyway.

Patch applied.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Arun Kollan 2016-04-16 23:49:22 Grant wizard styling
Previous Message Dave Page 2016-04-16 23:00:54 pgAdmin 4 commit: Ensure runtime settings are synced after they are upd