Re: Review Request 306: RM 33614 - Autocommit on/off option in PEM client

Ashesh; can you review/commit this please?

Thanks.

On Tue, Mar 24, 2015 at 11:57 AM, Sanket Mehta <
sanket(dot)mehta(at)enterprisedb(dot)com> wrote:

> Hi,
>
> I have developed the *Autocommit* feature in pgadmin and its patch is
> attached with this mail.
> Please do review and commit it.
>
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Tue, Mar 17, 2015 at 2:01 AM, Sanket Mehta <
> sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
>
>> This is an automatically generated e-mail. To reply, visit:
>> https://scm.enterprisedb.com/reviews/r/306/
>> Review request for Postgres Enterprise Manager, Akshay Joshi and
>> Ashesh Vashi.
>> By Sanket Mehta.
>> *Repository: * PEM
>> Description
>>
>> In Autocommit on/off option in pem client:
>>
>> "Enable autocommit" option is provided in pem client at 2 places:
>>
>> 1. pem client -> File menu -> Options -> Query Editor -> Enable AUTO COMMIT
>> 2. sql query tool -> Query menu -> Auto-commit
>>
>> User can select/deselect its value from any of the above 2 places and it will be reflected to other one.
>>
>> In any query tool session, once user uncheck this checkbox, depending upon postgreSQL standard for executing the query it will execute "BEGIN;" statement first at the time of executing the query and thus setting the autocommit off for that session.
>>
>> User can set the autocommit on at any time by selecting the checkbox from above mentioned places.
>> But it will be active only after user has completed the transaction block(started by BEGIN as mentioned above) by END or ROLLBACk or COMMIT;
>>
>>
>> Testing
>>
>> - setting autocommit on/off from client window.
>> - setting autocommit on/off from query tool.
>> - Setting the autocommit mode on/off in database
>>
>> Diffs
>>
>> - pgadmin/ui/frmOptions.xrc (a57b0ce)
>> - pgadmin/include/frm/menu.h (fb20b60)
>> - pgadmin/include/frm/frmQuery.h (c698370)
>> - pgadmin/frm/frmQuery.cpp (23ec45b)
>> - pgadmin/frm/frmOptions.cpp (4b3b1f1)
>> - docs/en_US/options-query_tool.rst (0b557e7)
>>
>> View Diff <https://scm.enterprisedb.com/reviews/r/306/diff/>
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company