| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d |
| Date: | 2018-06-25 14:17:40 |
| Message-ID: | CA+OCxoyCFZgqa5qKxatwVp9kQ8PO7_EXTWZTZgtNKDwRv=cTyg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached patch for RM #3309 - Backup does not work with
> --format=d.
>
> Fixes in the patch :
>
> 1. Format = directory fix for Backup and Restore utilities
> 2. Test cases for format = directory
> 2. File manager fix - The selected directory was not properly populated in
> the text box
>
The patch disables the file picker button if you select Directory format.
This seems like poor behaviour; I think we need to modify the dialogue to
allow a directory to be selected.
> 3. Refactoring of File manager JS file
>
That's somewhat more readable. Can we add tests?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Khushboo Vashi | 2018-06-25 14:33:58 | Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d |
| Previous Message | Akshay Joshi | 2018-06-25 14:08:02 | [pgadmin4][Patch]: Fixed RM 3442, 3443, 3444 Drop options not available. |