Re: [PATCH] Beautify line-ends handling yet more.

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Nikolai Zhubr <n-a-zhubr(at)yandex(dot)ru>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Beautify line-ends handling yet more.
Date: 2015-10-09 13:31:02
Message-ID: CA+OCxoy4Oo2WEXqU5_3nnka759FM1BtqZCKZovE1xKfJavr41w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Wed, Oct 7, 2015 at 7:47 PM, Nikolai Zhubr <n-a-zhubr(at)yandex(dot)ru> wrote:
> Hello Dave,
>
> Attached are two more patches, mostly cosmetic:
>
> * Make a better guess of default line-end type based on platform type.

I committed a modified version of this - Mac OS X uses \n as a
line-end, so that makes a better default than the old-style \r used on
Mac classic.

> * Get rid of #ifdef -- let wxTextBuffer::Translate do all the work.

Committed.

> Sending as attachments, let me know if inserting inline is preferred.

Please use attachments created with "git diff > foo.diff". I had to
manually apply the patches above for some reason, but git diff should
usually work fine (and inlining them is just painful!) :-)

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikolai Zhubr 2015-10-10 12:33:47 Re: [PATCH] Beautify line-ends handling yet more.
Previous Message Dave Page 2015-10-09 13:28:08 pgAdmin III commit: Get rid of #ifdef -- let wxTextBuffer::Translate do