| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Adding more confirmations in query tool (pgAdmin4) |
| Date: | 2016-09-07 13:00:26 |
| Message-ID: | CA+OCxoy0ZVietUm3piNLjApyUwnqZBUGSUPq_ct=Mfh6WQn=DA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Wed, Sep 7, 2016 at 10:38 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to add more confirmations in query tool before taking any actions
> which might cause lose changes,
> - Clearing editor
> - Clearing history
> - Load file data
> RM#1666
>
> Please review.
Can you tweak it so that the confirmation is requested as soon as the
open file button is clicked, rather than when a file is selected
please? I think that's a little more 'normal' :-).
Thanks!
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2016-09-07 13:01:59 | pgAdmin 4 commit: Fix typo in connection handler. |
| Previous Message | Surinder Kumar | 2016-09-07 11:46:44 | [pgAdmin4][Patch]: RM1581 - When switching between query tabs, the selected tab is not ready to run a query |