Re: Regarding non-ascii characters in the path for Windows installer

On Mon, 20 Jan 2025 at 08:26, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

>
>
> On Fri, Jan 17, 2025 at 5:32 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thu, 16 Jan 2025 at 11:23, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
>> wrote:
>>
>>> Hi Dave/Hackers
>>>
>>> I am looking into issue 5204
>>> <https://github.com/pgadmin-org/pgadmin4/issues/5204> where the pgAdmin
>>> 4 Windows installer throws an error of "Please provide a valid path," when
>>> the user name contains non-ASCII characters.
>>>
>>> We have added a function IsPathValid to validate the path in the "
>>> installer.iss.in" file, because of this function Windows installer
>>> throws an error.
>>>
>>> [image: Code.png]
>>> Can we remove this logic? Thoughts/Suggestions?
>>>
>>
>> I don't think we can just remove it - if memory serves, we added it
>> because we ran into issues in some cases. Obviously we can't do an
>> exhaustive test, but can we confirm that pgAdmin will work with at
>> least some non-ASCII characters in the path, e.g. some accented characters,
>> Kanji, Cyrillic etc?
>>
>
> We added this function in 2017 to address issue #1365
> <https://redmine.postgresql.org/issues/1365>. The issue reported that
> pgAdmin would not launch after installation. At that time, we were using QT
> (Mingw), which is no longer used.
> For testing purposes, I removed the function call from the
> installer.iss.in file and conducted tests using the following username:
>
> [image: Screenshot 2025-01-20 at
> 1.30.44 PM.png]
>
> The user names mentioned above include accented characters, Kanji, and
> Cyrillic scripts. pgAdmin 4 was installed and ran successfully without any
> issues.
> Let's remove that function. Thoughts/Suggestions?
>

Seems reasonable to me, given the original motivation and your testing.

Thank you!

--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com