Re: Require sugeestion for #1235

Hi

On Wed, 12 Feb 2025 at 11:25, Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> Design was inspired by the File menu of different editors. Here is a
> screenshot for VS code. However, the Open option here always opens the file
> in a new tab.
>

A File menu is quite different from a toolbar button.

>
> [image: Screenshot 2025-02-12 at 4.50.59 PM.png]
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Wed, Feb 12, 2025 at 4:35 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Wed, 12 Feb 2025 at 10:44, Yogesh Mahajan <
>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>
>>> Dave/Team,
>>>
>>> I think, major votes are on the design #3 - Combine all file operations
>>> menu in single dropdown.
>>>
>>
>> I don't recall ever seeing that design pattern. Do you have any examples?
>>
>>
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>>
>>> On Fri, Feb 7, 2025 at 12:13 PM Usman Khan <umk555(at)gmail(dot)com> wrote:
>>>
>>>> Hi Yogesh,
>>>>
>>>> I am in favour of the third option you pointed out above but in that
>>>> case I suggest changing the icon accordingly as the current icon usually
>>>> gives clue about 'file-opening' operation.
>>>>
>>>> Thanks
>>>>
>>>> On Fri, Feb 7, 2025 at 11:31 AM Aditya Toshniwal <
>>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Yogesh,
>>>>>
>>>>> I am in favor of the "Combine all file operations menu in single
>>>>> dropdown" solution. It is more in-line with menus of other editors and is
>>>>> more intuitive.
>>>>>
>>>>> On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
>>>>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Could you please provide your feedback/suggestions?
>>>>>>
>>>>>> Thanks,
>>>>>> Yogesh Mahajan
>>>>>> EnterpriseDB
>>>>>>
>>>>>>
>>>>>> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
>>>>>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> For issue #1235
>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/1235> - Query Tool
>>>>>>> - Open file should open file in a new tab, here are two the options to set
>>>>>>> preference for opening file.
>>>>>>> 1.Provide split button beside Open file button -
>>>>>>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>>>>>>> Pros -
>>>>>>> a.Provides an easy way to set up the preference.
>>>>>>> Cons -
>>>>>>> a.One more addition of icon.
>>>>>>>
>>>>>>>
>>>>>>> 2.Provide option with save button dropdown -
>>>>>>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>>>>>>> Pros -
>>>>>>> a.No need to add a split button for the open icon.
>>>>>>> Cons -
>>>>>>> a.Open operation is listed under save options.
>>>>>>>
>>>>>>>
>>>>>>> 3.Combine all file operations menu in single dropdown -
>>>>>>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>>>>>>
>>>>>>> Pros -
>>>>>>> a.All file related options are clubbed together like most of the
>>>>>>> editors.
>>>>>>> b.Allows to add more file operations with the same dropdown.(Like
>>>>>>> Open recent - however this is out of scope of this issue.)
>>>>>>> Cons -
>>>>>>> c.Can't think of any.
>>>>>>>
>>>>>>> Could you please share your suggestions?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Yogesh Mahajan
>>>>>>> EnterpriseDB
>>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Thanks,
>>>>> Aditya Toshniwal
>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>>> <https://www.enterprisedb.com/>
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> pgEdge: https://www.pgedge.com
>>
>>

--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com