From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
Cc: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Fixes for pgAdmin4 messages |
Date: | 2017-11-05 13:36:45 |
Message-ID: | CA+OCxoxxuga_ecuWjxFYArY38BBb1z4nWQehcCpy9q9DGWEqgA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
That looks like it - thanks, applied!
On Sat, Nov 4, 2017 at 2:25 AM, Alexander Lakhin <exclusion(at)gmail(dot)com>
wrote:
> Hello,
>
> 04.11.2017 07:05, Ashesh Vashi wrote:
>
> Looks like - the patch has introduced syntax error in database.js.
>
> On Nov 3, 2017 22:19, "Dave Page" <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> Unfortunately I've had to revert this. It was causing the treeview to
>> render incorrectly (see the attached screenshot).
>>
>> Can you take a look please? I've CC'd Ashesh as he knows that area of the
>> code far better than I do and may be able to spot the issue much more
>> quickly (plus I'm travelling from tomorrow AM, and will have limited
>> availability).
>>
> Sorry, the error was caused by 'gettext' import missing in variable.js.
> Please apply the fixed version.
>
> On Fri, Nov 3, 2017 at 1:14 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Fri, Nov 3, 2017 at 10:52 AM, Alexander Lakhin <exclusion(at)gmail(dot)com>
>>> wrote:
>>>
>>>> Hello,
>>>> I have another patch for the better localization of pgAdmin4.
>>>> Please consider applying it.
>>>>
>>> ------
> Alexander Lakhin
> Postgres Professional: http://www.postgrespro.com
> The Russian Postgres Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-11-05 13:38:11 | Re: Polish translation for current version of pgadmin4 |
Previous Message | Dave Page | 2017-11-05 13:36:28 | pgAdmin 4 commit: Update Polish translation. |