From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: Fixed typo in Server node |
Date: | 2016-05-06 12:58:54 |
Message-ID: | CA+OCxoxxer8WrntwcctX_s7hQhqLTA6SSa_4TM7H7bx0zN3P3w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks - applied.
On Fri, May 6, 2016 at 11:14 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Looks like below given commit has left a typo in the code, I’m getting error
> while updating any Server node,
>
> Commit:
> 0628ee04 web/pgadmin/browser/server_groups/servers/__init__.py (Dave Page
> 2016-05-05 16:42:16 +0100 377)
> node=self.blueprint.generate_browser_node(
>
> Error:
> return method(*args, **kwargs)
> File
> "/Users/murtuza/Desktop/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
> line 385, in update
> server_type='pg' # default server type
> TypeError: make_json_response() got an unexpected keyword argument ‘node'
>
>
>
> PFA patch to fix the issue.
>
>
>
> Regards,
> Murtuza
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2016-05-06 13:26:50 | PATCH: Initiale for "Restore Utility" [pgAdmin4] |
Previous Message | Dave Page | 2016-05-06 12:58:48 | pgAdmin 4 commit: Fix a typo introduced in a merge. |