Re: Patch for Redmine Bug 5587

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Paresh More <paresh(dot)more(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Subject: Re: Patch for Redmine Bug 5587
Date: 2020-06-22 11:16:15
Message-ID: CA+OCxoxvEfd1=v4SAEiVM+SUe4N+_QeB5z7ASiw5QEYtCiEFBg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied with some spelling fixes :-p

Akshay, please have one of the team test this thoroughly.

On Mon, Jun 22, 2020 at 8:31 AM Paresh More <paresh(dot)more(at)enterprisedb(dot)com>
wrote:

> Hello Dave,
>
> This is regarding issue #5587 (Handle Windows x32/x64 installation using
> Innotool)
> https://redmine.postgresql.org/issues/5587
>
> This patch will make sure the following thing
>
>
> - pgAdmin4 windows installer should restrict the user not to install
> 32bit and 64bit parallelly.
> - It should not allow pgAdmin4 install x64 if x32 is installed Or vice
> versa, only upgrade of the same type should be allowed.
>
>
> - If user has already installed 32bit installer and try to install
> 64bit it should throw an error as "You already have a 32bit installation of
> pgAdmin 4. Please uninstall this before installing the 64bit version."
>
>
> - If user has already installed 64bit installer and try to install
> 32bit it should throw an error as "You already have a 64 bit installation
> of pgAdmin 4. Please uninstall this before installing the 32 bit version."
>
>
> It's working fine at my end.
>
> Attached is the patch for the same.
>
>
> --
>
> Thanks & Regards
>
> *Paresh More*
>
> [image: NEW-EDB-logo-4c]
>
> Pune, India.
> Cell : +919922000564 | www.enterprisedb.com
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-06-22 12:13:50 pgAdmin 4 commit: Documentation of Row Level Security Policies. Fixes #
Previous Message Dave Page 2020-06-22 11:15:35 pgAdmin 4 commit: Disallow installation of the 32 and 64 bit builds at