From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch] - RM 3959 - Properties and Dependents tabs rendering is slow with 1000+ records |
Date: | 2019-02-14 11:18:33 |
Message-ID: | CA+OCxoxub0PLFKu9+TEEVLyt7dSnUmapQSXxBGD+ab8yV9-QFQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
Thanks - patch applied.
I did spot another minor issue whilst testing - it's clearly not
caused by this patch though so I've logged it as #3994.
On Thu, Feb 14, 2019 at 9:55 AM Khushboo Vashi
<khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Thu, Feb 14, 2019 at 3:05 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Thu, Feb 14, 2019 at 5:44 AM Khushboo Vashi
>> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>> >
>> > Hi,
>> >
>> > Please find the attached patch to fix the RM #3959 - Properties and Dependents tabs rendering is slow with 1000+ records.
>>
>> There are a couple of PEP-8 issues (easy fixes),
>
> Fixed
>>
>> but more serious is
>> that the object icons are no longer being displayed on each row of the
>> tables.
>>
> Fixed
>>
>> Can you look into that please?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2019-02-14 14:44:45 | RM2233 - Scratch pad |
Previous Message | Dave Page | 2019-02-14 11:15:05 | pgAdmin 4 commit: Optimise display of Dependencies and Dependents, and |