Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220

On Thu, Oct 20, 2016 at 12:08 PM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> On Thu, Oct 20, 2016 at 4:26 PM, Khushboo Vashi
> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>
>>
>> On Sat, Oct 15, 2016 at 11:52 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>
>>>
>>> On Friday, October 14, 2016, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
>>> wrote:
>>>>
>>>> On Sat, Oct 15, 2016 at 4:59 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>
>>>>> Hi
>>>>>
>>>>> On Friday, October 14, 2016, Khushboo Vashi
>>>>> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find the attached patch to fix the below 2 bugs.
>>>>>>
>>>>>> RM 1603: [Web Based] Export database failed if object contains double
>>>>>> quotes.
>>>>>> RM 1220: Backup database is not working with special characters
>>>>>>
>>>>>> The issues which were fixed:
>>>>>>
>>>>>> 1. Client side data were not unescaped
>>>>>> 2. Required command line arguments were quoted twice
>>>>>
>>>>>
>>>>> This is not working for me: I tested using Table Export as per Fahar's
>>>>> instructions. As I'm in desktop mode, the first problem was that we get an
>>>>> error at line 210 of import_export/__init__.py, because get_server_directory
>>>>> returned None for the directory. If I fix that, then the job says it's
>>>>> created, but as far as I can see, nothing else happens.
>>>>
>>>> hmm..
>>>
>>>
>>> Yes, but please see my followup message. There's clearly something funky
>>> going on with the process tracking - for whatever reason it didn't pick up
>>> this process until after a restart, and per the bug I escalated earlier
>>> (which I think is essential to fix for 1.1 in a little over a week), it
>>> doesn't always detect completed processes and then keeps re-showing the
>>> alert.
>>>
>>
>>
>> The problem here is that, until we click the "Click for details here" link
>> and close the another details dialogue, the acknowledgement does not send to
>> the server. So, it keeps re-showing the alert.
>>
>> I think, we need to clearly mention the steps on the alertify notifier
>> itself, so the user can get the idea.
>>
>> Dave/Ashesh,
>> Any other suggestion?
>
> We can give a acknowledge link along with 'Click here for details' link to
> delete the status, logs, when clicked.
> Dave?

Sure, we can do that - but with so many instances being reported,
clearly there's a root cause to fix first.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company