Re: PATCH: PGADMIN 4 - FTS templates node

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: PGADMIN 4 - FTS templates node
Date: 2016-04-07 09:09:54
Message-ID: CA+OCxoxtJ5hqAzVADHP-+49PCFqb-xiSeQtGfYjSeK2wcKvnmA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Mar 28, 2016 at 10:01 AM, Sanket Mehta
<sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> I have found out the root cause of this issue.
>
> This issue is occurring at your side as you are using python 2.7 so in that
> case sql query returned from sql template is of type 'unicode'.
> And in __init__.py file we have checked if the sql query is of string type
> then only we would proceed further.
>
> I was not getting this issue as I was using python 3.0
>
> I have resolved this issue and some other typo errors in comments and patch
> is attached with this mail.
>
> Please do review it and let me know in case of any issues.

Did you send the right patch? I'm still getting the error
(specifically, when rendering update.sql, render_template throws an
exception "can't adapt type 'Undefined'")

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Arun Kollan 2016-04-07 09:42:34 Styling tab navigation and close buttons
Previous Message Akshay Joshi 2016-04-07 09:07:19 Re: [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool