Re: [pgAdmin4][PATCH] Fix the issue in browser tree

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][PATCH] Fix the issue in browser tree
Date: 2017-04-07 08:29:30
Message-ID: CA+OCxoxrDHGFwnO49+iHeKuuWX+d+vHDz-+xVk1Cti0LAMYLYQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hmm, I think this might have broken adding of new nodes in some cases. I
just added two new tables (right-clicking the public schema), and had to
refresh the tables node before they showed up.

On Fri, Apr 7, 2017 at 4:29 AM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
wrote:

> Thanks - committed!
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
> On Thu, Apr 6, 2017 at 11:21 AM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hello,
>>
>> PFA patch to fix the issue in browser tree when adding new node if parent
>> collection node is not loaded.
>> *Fixes:* RM#2321
>>
>> Steps:
>> 1) Open pgAdmin4.
>> 2) Do not expand server-group node.
>> 3) Right click on server-group collection node and add server, now click
>> on save button
>> (This issue is reproducible on any collection node which is not loaded)
>> 4) You will see that only newly added node is displayed in browser tree
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2017-04-07 08:43:28 Re: [pgAdmin4][PATCH] Fix the issue in browser tree
Previous Message Ashesh Vashi 2017-04-07 03:29:49 Re: [pgAdmin4][PATCH] Fix the issue in browser tree