Re: [INSTALLERS] pgAdmin 4: Add-on support

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Fahar Abbas <fahar(dot)abbas(at)enterprisedb(dot)com>
Subject: Re: [INSTALLERS] pgAdmin 4: Add-on support
Date: 2018-01-04 09:24:32
Message-ID: CA+OCxoxprYj6_s9w__=rtyPjwov1EdObKkkzs=O6OGpy_bYO=w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Jan 3, 2018 at 1:04 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
wrote:

> Gentle Reminder. :-)
>
> FYI - I've rebased this branch from origin/master.
>

Tarball and Windows installer creation spat out the following error, then
continued anyway:

[INFO]: +++ Building the module - 'codemirror'...
[INFO]: +++ Module Built! (Name: codemirror, Time: 8093ms)
[INFO]: +++ Building the module - 'react'...
[INFO]: +++ Module Built! (Name: react, Time: 7416ms)
[INFO]: +++ Building the module - 'vendor'...
[INFO]: +++ Module Built! (Name: vendor, Time: 51483ms)
[INFO]: +++ Building the module - 'slickgrid'...
[INFO]: +++ Module Built! (Name: slickgrid, Time: 5190ms)
[INFO]: +++ Building the module - 'core'...
Error building the module - 'core' with error code: 2!
Error: Command failed: node ./node_modules/webpack/bin/webpack.js -p
--config webpack.config.js

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this
command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this
command.
Adding pgadmin/static/css/generated
Adding pgadmin/static/js/generated
Adding webpack/references/core.json
Adding webpack/references/react.json
Adding webpack/references/vendor.json
~/git/pgadmin4
Creating tarball...

>
> -- Thanks, Ashesh
>
> On Wed, Dec 13, 2017 at 8:36 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> The code is broken right now - see https://redmine.postgresql
>> .org/issues/2952. Once it's fixed, I can do this, assuming I can find
>> the spare time.
>>
>
>> On Thu, Dec 7, 2017 at 4:05 PM, Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave,
>>>
>>> I've merged the master branch in the 'WEBPACK_DEVEL2' branch.
>>>
>>> In this branch, I've modified the code for adding back the support of
>>> pluggability, which was broken due to webpack changes.
>>>
>>> Would you please create the set of installers?
>>> And, share it with Fahar for doing the integration testing after these
>>> changes.
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi>
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2018-01-04 17:55:29 pgAdmin 4 commit: Fixed regression (typos) introduced during the 'pgadm
Previous Message Ashesh Vashi 2018-01-04 04:49:14 pgAdmin 4 commit: Doc updates for server connection dialogue and relate