Re: [Patch] Python 3 compatibility

From: Dave Page <dpage(at)pgadmin(dot)org>
To: George Gelashvili <ggelashvili(at)pivotal(dot)io>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [Patch] Python 3 compatibility
Date: 2017-01-20 15:30:28
Message-ID: CA+OCxoxpX+vZeWVGe8LNBxdDyU9HksXM5GLnOCUPOeD9epSEaQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Thu, Jan 19, 2017 at 10:12 PM, George Gelashvili
<ggelashvili(at)pivotal(dot)io> wrote:
> Hello
>
> We stumbled on the following error when running tests off of master:
>
> Traceback (most recent call last):
> File "web/regression/runtests.py", line 254, in <module>
> servers_info = test_utils.get_config_data()
> File "/Users/pivotal/workspace/pgadmin4/web/regression/test_utils.py",
> line 72, in get_config_data
> if (not srv.has_key('enabled')) or srv['enabled'] == True:
> AttributeError: 'dict' object has no attribute 'has_key'
>
> Please find attached a fix for this.
>
> - George & Tira
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-01-20 15:38:21 Re: Acceptance Tests against a browser (WIP)
Previous Message Dave Page 2017-01-20 15:30:02 pgAdmin 4 commit: Python 3 fix for the regression tests