Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

Thanks, patch applied.

On Fri, Dec 16, 2016 at 12:02 PM, Khushboo Vashi
<khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached patch to fix the regression bug due to this (RM
> 1801) fix.
>
> Issue: While creating database, gets an error while changing the tab to SQL
> tab.
>
> Thanks,
> Khushboo
>
>
>
>
>
>
>
> On Fri, Dec 9, 2016 at 5:29 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Thanks, patch applied.
>>
>> On Fri, Dec 9, 2016 at 5:32 AM, Khushboo Vashi
>> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>> > Hi,
>> >
>> > Please find the attached updated patch.
>> >
>> > Thanks,
>> > Khushboo
>> >
>> > On Mon, Dec 5, 2016 at 11:09 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Friday, December 2, 2016, Khushboo Vashi
>> >> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>> >>>
>> >>> Hi.
>> >>>
>> >>> Please find the attached updated patch.
>> >>>
>> >>> Thanks,
>> >>> Khushboo
>> >>>
>> >>> On Fri, Nov 25, 2016 at 7:12 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> >>>>
>> >>>> Hi
>> >>>>
>> >>>> On Fri, Nov 25, 2016 at 12:19 PM, Khushboo Vashi
>> >>>> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>> >>>> > Hi,
>> >>>> >
>> >>>> > Please find the attached updated patch.
>> >>>>
>> >>>> Please see the attached screenshot. It's still offering to let me
>> >>>> connect to a database with datallowconn=false, or create objects in
>> >>>> it.
>> >>>>
>> >>> Fixed.
>> >>>
>> >>>>
>> >>>> It also doesn't display the properties or dashboard for it if I click
>> >>>> on it - it just silently keeps displaying the properties/dashboard
>> >>>> for
>> >>>> the previous database.
>> >>>>
>> >>> Fixed.
>> >>
>> >>
>> >> I'm still seeing graphs being generated when I've selected a template
>> >> database with datallowconn = true. What is it showing me? I'm seeing
>> >> transactions, tuple and block I/O, which I would not expect from a
>> >> database
>> >> that noone can connect to.
>> >>
>> >
>> > Fixed
>> >
>> >>
>> >> Thanks.
>> >>
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >>
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company