Re: [pgAdmin4][Patch]: Fixed RM #3295 - Shortcut key conflict issue

Thanks - patch applied!

On Fri, May 18, 2018 at 7:15 AM, Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Just to add, the previous patch was not working because, firefox does not
> focus a div element if it does not have tabindex(value greater than -1)
> attribute (somehow it works in chrome).
> self.docker.$container referred to div(class-wcDocker) which does not have
> tabindex attribut. So changed the code to focus its parent div(#container)
> which have the tabindex="0" attribute.
> I have added the comments in code also.
>
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>
> On Fri, May 18, 2018 at 11:34 AM, Aditya Toshniwal <aditya.toshniwal@
> enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> PFA updated patch for RM#3295. The patch is to fix the issue in firefox
>> also.
>> Kindly review. Please try in firefox also.
>>
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>> On Wed, May 9, 2018 at 6:58 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Thanks, applied.
>>>
>>> On Wed, May 9, 2018 at 2:10 PM, Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch to fix RM #3295: Shortcut key conflict
>>>> issue
>>>>
>>>> After opening the debugger, the shift+alt+o short-cut opens the Object
>>>> menu as well as perform the step over to the debugger. This issue has been
>>>> fixed in this patch.
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company