Re: PATCH: To fix the issue on Table collection node refresh (pgAdmin4)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix the issue on Table collection node refresh (pgAdmin4)
Date: 2016-09-14 09:33:50
Message-ID: CA+OCxoxnD8j8nUxHzQFZOC-Y37dqjmW81_yHhutHwp7r1CoPyQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Tue, Sep 13, 2016 at 8:58 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix the issue where user tries to refresh on Table collection
> node it was throwing error.
> RM#1686
>
> Issue: Nodes method was not implemented properly to handle such request in
> Table node.
>
> Also attaching a separate patch for typo in browser.js file due to which
> this error was displaying on console and not on GUI.
>
> @Ashesh, Would you please review this minor patch (File:
> misc_typo_fix.patch), I hope it does not affect anything else :)
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Devrim Gündüz 2016-09-14 09:37:32 pgadmin4 RPMs need some testing!
Previous Message Dave Page 2016-09-14 09:33:44 pgAdmin 4 commit: Fix a typo in the error handling in the browser that