| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Shirley Wang <swang(at)pivotal(dot)io> |
| Cc: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, Anthony DeBarros <adebarros(at)gmail(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Design Update] Visual design of query editor and results table |
| Date: | 2017-04-06 14:31:21 |
| Message-ID: | CA+OCxoxmsrNNhXtoU3z_10hHmN2nq-LaeguaQeXJYTpnTRcW6g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Thu, Apr 6, 2017 at 3:27 PM, Shirley Wang <swang(at)pivotal(dot)io> wrote:
> Thanks, all!
>
>>
>> On Wed, Apr 5, 2017 at 4:55 PM, Anthony DeBarros <adebarros(at)gmail(dot)com>
>> wrote:
>>>
>>> I like the changes overall. Feels polished.
>>>
>>> For mockup purposes, remember that pgAdmin 4 behavior right-justifies
>>> integers, numerics, etc., for readability.
>>>
>
> Anthony, I left-justified integers in the table for three reasons:
> 1. it aligns better with the table headers
> 2. it provides more consistent spacing between results making it easier to
> read
> 3. right-justified numbers come from precedents like excel or other
> spreadsheet type tools and muddles the distinction between editable and
> un-editable tables (at least data output in from query results is
> un-editable, I know right clicking on a table in the browser to "view ...
> data/rows" outputs an editable table)
When we first released pgAdmin 4 we forgot to right-justify numbers.
Users complained. Lots. They need to stay right justified.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2017-04-06 14:34:08 | pgAdmin 4 commit: Swap entries in karma.conf so test-main.js is matched |
| Previous Message | Shirley Wang | 2017-04-06 14:27:20 | Re: [Design Update] Visual design of query editor and results table |