| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query |
| Date: | 2018-06-21 00:50:52 |
| Message-ID: | CA+OCxoxkuv7863HAB10fxUeJUezDBSNW4awos6-eDgK9-_UZkw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:
> Hi Hackers,
>
> Attached is the patch for Feature #3273 Add ability to sort in the Select
> File window when opening a saved query.
>
> I haven't seen any refactoring possibility, patch contains feature test
> with *time.sleep(0.05). *I have spend lot of time to not introduce
> "time.sleep()" and tried couple of different ways of WebDriveWait, but
> didn't get success.
>
> Please review it.
>
I get the following running the feature tests:
invalid syntax (xss_checks_file_manager_test.py, line 60)
make: *** [check-feature] Error 1
Also; should that file be renamed now, to reflect that it tests more than
just XSS?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2018-06-21 05:27:18 | Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query |
| Previous Message | Aditya Toshniwal | 2018-06-20 14:17:22 | Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database. |