From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Atira Odhner <aodhner(at)pivotal(dot)io> |
Cc: | Joao Pedro De Almeida Pereira <jpereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [patch] Test dependencies and screenshots |
Date: | 2017-03-07 13:48:59 |
Message-ID: | CA+OCxoxkQQLwF18dceDozB28TtJ6ucqX4hL8o9sHH8Q94ZJM-Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Fri, Mar 3, 2017 at 6:41 PM, Atira Odhner <aodhner(at)pivotal(dot)io> wrote:
> Hey Dave,
>
> We're not able to reproduce that issue over here. Any chance you could debug
> it?
Per the discussion at
https://github.com/seleniumhq/selenium-google-code-issue-archive/issues/3378,
it looks like we're not closing the driver in the correct way (one
would think that close() means exit and cleanup whilst quit() means
bail out without regard for everyone else, but apparently not...).
Anyway, the attached patch seems to fix the issue for me on my laptop.
I'll go commit it - please yelp if you object.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
feature_test_zombies.diff | text/plain | 524 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-03-07 13:49:57 | pgAdmin 4 commit: Avoid leaving chromedriver processes cluttering the l |
Previous Message | Dave Page | 2017-03-07 13:43:19 | Re: Three minor changes + GER |