Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger

Hi

This seems to be missing documentation updates. I would also expect to see
some Jasmine unit tests for some/all of the new JS functions.

On Tue, Jan 16, 2018 at 1:29 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA patch to add keyboard navigation in Debugger module via
> Tab/Shift-Tab key.
> RM#2897
>
> Also fixed the issue where user was not able to update values in
> variable's panel while debugging.
> RM#2981
>
> Currrently we have execution related shortcuts using accesskey,
> Shortcuts (Execution related)
> ----------------------------------
> <accesskey> + i = Step in
> <accesskey> + o = Step over
> <accesskey> + c = Continue/Restart
> <accesskey> + t = Toggle breakpoint
> <accesskey> + x = Clear all breakpoints
> <accesskey> + s = Stop
>
> Shortcuts (Panel navigation related)
> ----------------------------------
> Alt + Shift + Right Arrow
> Alt + Shift + Left Arrow
>
> Edit/Enter values in Grid (Parameter & Local variables panel's)
> -------------------------------------------------------------
> Alt + Shift + g
>
> Please review.
>
> *Note:* As of now inner panel's are not getting focused on Tab/Shift-Tab
> keys but once RM#2895 <https://redmine.postgresql.org/issues/2895> patch
> gets committed it will start working automatically as it's inherited code
> which will add tabindex tag automatically on each newly created wcDocker
> panel.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company