Re: [pgadmin4][patch] Use pytest test runner for unit tests

Hi

On Tue, Jun 12, 2018 at 3:41 PM, Victoria Henry <vhenry(at)pivotal(dot)io> wrote:

> Hi Dave,
>
> Attached are four different patches that should be applied in order.
> Included is a fix for the failing test above.
>

This is no longer failing :-)

However, I'm still seeing problems that need to be resolved:

- Passwords are still being written to the log file. This is a complete
show-stopper.

- The regression.log file is empty. I'm now only getting the JSON summary.
We really need both - the regression log for diagnostics, and the JSON file
for feeding into monitoring systems.

- There is still no summary list of tests that failed or were skipped
output at the end of the run. This is important because it highlights which
tests failed (obviously!) and need investigation, and knowing which ones
are skipped at a glance is very useful as they can be skipped due to
mis-configuration; e.g. running against a different server than intended,
or failing to specify something like a tablespace path which we can then
easily see to fix.

- I cannot run against servers other than the first one in the config file.
We need to run against all that are enabled, and have the output show which
one was used for each one as we have now. This may seem trivial, but it's
really not - to the point that for some of us it negates the whole point of
the patch by giving us more control over which tests are run but removing
all control over which database servers they will run against. In my case,
this will almost certainly cost even more time; right now I just have to
run more tests than I may need but I can do other things at the same time.
With this patch I'll have to keep re-running the tests, modifying the
config between each run.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company