From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
Subject: | Re: pgAdmin 4 commit: Update docs to more accurately reflect the SERVER_MOD |
Date: | 2017-08-29 08:42:54 |
Message-ID: | CA+OCxoxcTsXFkHfiz0N96ai14QsTgtZY_vTXKxyPNWVnHTGpPw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Mon, Aug 28, 2017 at 7:51 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:
> Hi Dave
>
> Changes looks good to me, only one thing is that I also override
> 'DATA_DIR' and 'TEST_SQLITE_PATH' parameter in my config_local.py, so we
> should include both the parameters in 'desktop_deployment.rst' file.
>
DATA_DIR is only used to derive the other paths isn't it? and
TEST_SQLITE_PATH is a developer option, so I'm inclined to leave that out
of the user docs.
>
> On Fri, Aug 25, 2017 at 4:45 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Akshay, Ashesh,
>>
>> I've committed these doc changes to reflect the paths/SERVER_MODE
>> changes. Could you both please review them and let me know if I missed
>> anything of importance, or if anything isn't clear?
>>
>> Thanks.
>>
>> On Fri, Aug 25, 2017 at 12:13 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Update docs to more accurately reflect the SERVER_MODE config
>>> requirements.
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>> f;h=5c016f0993fb557052cce7e11cd6ad818bd7c3a3
>>>
>>> Modified Files
>>> --------------
>>> docs/en_US/desktop_deployment.rst | 39 ++++++++++--------------------
>>> ---------
>>> docs/en_US/server_deployment.rst | 18 ++++++++----------
>>> 2 files changed, 18 insertions(+), 39 deletions(-)
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Harshal Dhumal | 2017-08-29 09:27:02 | Re: pgAdmin 4 commit: Fix the feature tests failuers. |
Previous Message | Dave Page | 2017-08-29 08:18:05 | Re: pgAdmin 4 commit: Fix the feature tests failuers. |