Re: [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited
Date: 2016-09-23 12:30:18
Message-ID: CA+OCxoxaYdKVbmEN-zJG5N_wrXViznkngdHwOpM563Jt+Vxe0Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Umm, no it wasn't - sorry.

I see the same issue with Types. Can you fix that, and check all other
nodes as well please?

Thanks.

On Fri, Sep 23, 2016 at 1:29 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Thanks, applied.
>
> On Fri, Sep 23, 2016 at 12:05 PM, Surinder Kumar
> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> Hi,
>>
>> Please find updated patch with changes:
>> 1) On debugging through JS files, the issue was in synonym update method
>> which wasn't returning node object.
>> 2) retrieving schema name in node.sql for creating node object in update
>> method.
>>
>> Please review and let me know for comments.
>>
>> On Fri, Sep 23, 2016 at 2:44 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>> Hi
>>>
>>> On Fri, Sep 23, 2016 at 7:39 AM, Surinder Kumar
>>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>> > Hi
>>> >
>>> > Issue:
>>> > on updating node, we deselect and then again select the node updated to
>>> > refresh the panel. but it needs some delay of few milliseconds between
>>> > deselect and select to fix this issue.
>>> >
>>> > Please find attached patch and review.
>>>
>>> This does not resolve the issue for me. I tested using a synonym to a
>>> package on EPAS 9.5, by changing the target package name.
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-09-23 20:34:46 Re: PATCH: pgAgent support
Previous Message Dave Page 2016-09-23 12:29:18 Re: [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited