Re: [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server
Date: 2016-10-03 12:51:08
Message-ID: CA+OCxox_11b1hTVeXuum+AktRMXwL5DVgzFxyRGpQvmgig0i3Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, committed.

On Fri, Sep 30, 2016 at 2:24 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Thanks.
>
> On Fri, Sep 30, 2016 at 2:08 PM, Surinder Kumar
> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> Dave, I have created RM #1786
>>
>> On Fri, Sep 30, 2016 at 6:32 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>> Is there an RM for this? If not, can you create one please? I want to
>>> be sure we capture all notable changes in Redmine.
>>>
>>> Thanks!
>>>
>>> On Fri, Sep 30, 2016 at 1:53 PM, Surinder Kumar
>>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>> > Hi
>>> >
>>> > When we add new server and enter an invalid port, it validates and
>>> > display
>>> > error message, but sometimes it doesn't unset errorModel when a valid
>>> > value
>>> > is entered.
>>> >
>>> > Please find attached patch and review.
>>> >
>>> >
>>> > Thanks,
>>> > Surinder Kumar
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-10-03 13:11:44 pgAdmin 4 commit: First cut of the pgAgent docs.
Previous Message Dave Page 2016-10-03 12:50:57 pgAdmin 4 commit: Ensure errorModel unset property properly in while ad