Re: [pgAdmin4][PATCH] Fix clicking on the "pgAdmin 4" header logo shows a empty dialog

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][PATCH] Fix clicking on the "pgAdmin 4" header logo shows a empty dialog
Date: 2017-06-20 09:29:05
Message-ID: CA+OCxoxVE88Rcd-7B5ajmFxTc2oTBOCr=K+f5v=PL+R+aBgpWQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Tue, Jun 20, 2017 at 5:54 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA minor patch to fix the issue, where user will get empty dialog in
> desktop mode if user clicks on pgadmin4 header logo. pgAdmin4 is already a
> SPA so in my opinion we don't require route to to home page.
> RM#2479
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-06-20 10:51:26 pgAdmin 4 commit: Create a runner for the feature tests.
Previous Message Dave Page 2017-06-20 09:28:39 pgAdmin 4 commit: No need for the menu icon to link to the homepage, as