Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control

Thanks - committed as the IE fixes, with the Jasmine stuff as a bonus :-)

On Thu, Jul 11, 2019 at 7:40 PM Ganesh Jaybhay <
ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> Please find the attached patch for jasmine tests fix. Patch also includes
> fixes for edit/delete cell focus on IE by Murtuza.
>
> Regards,
>
> Ganesh Jaybhay
>
> On Thu, Jul 11, 2019 at 3:49 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi Ganesh,
>>
>> It looks like this has broken the Jasmine tests (which I admit I forgot
>> to run before committing). Can you fix ASAP please?
>>
>> Thanks.
>>
>> On Thu, Jul 11, 2019 at 10:14 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Thanks - patch applied with some doc tweaks.
>>>
>>> No need for a new ticket!
>>>
>>> On Thu, Jul 11, 2019 at 7:00 AM Ganesh Jaybhay <
>>> ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> Ticket number 3919 refers to keyboard accessibility issues for sub-node
>>>> control and back grid but this patch covers only sub-node control. Should I
>>>> create new one?
>>>> I have added the screenshot having newly added shortcut and updated
>>>> keyboard shortcut rst file. Also moved the code changes from backgrid.js to
>>>> backgrid.pgadmin.js.
>>>>
>>>> Please find the attached updated patch.
>>>>
>>>> Regards,
>>>> Ganesh Jaybhay
>>>>
>>>> On Tue, Jul 9, 2019 at 9:28 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> What's the ticket number for this? That's a fair amount of code for a
>>>>> one-line description. There are also no doc changes describing how to
>>>>> navigate the sub-node control that I can see.
>>>>>
>>>>> Also; instead of changing the repo used for backgrid, can we not
>>>>> un-vendorise it?
>>>>>
>>>>> On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay <
>>>>> ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Attached is the patch for keyboard accessibility of sub-node control.
>>>>>> It also covers sub-node dialog forward/backward tab navigation with
>>>>>> shortcuts.
>>>>>>
>>>>>> Kindly review.
>>>>>>
>>>>>> Regards,
>>>>>> Ganesh Jaybhay
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company