Re: [pgadmin4][Patch]: Fixed minor issue in auto discover server when entry is blank in the config file

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin4][Patch]: Fixed minor issue in auto discover server when entry is blank in the config file
Date: 2018-06-21 20:35:01
Message-ID: CA+OCxoxP=UJA_gd8oO4_2HVF6q8W9=YAKZ+BRNymKo4g9kv+pw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Thu, Jun 21, 2018 at 8:32 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Hi Hackers,
>
> I have found one minor issue in auto discovery logic. *getint* function
> of ConfigParser throws exception if the value of the parameter is blank
> in the config file. Example: *Port=*
>
> Because of that exception pgAdmin4 unable to discover all the valid
> servers. Attached is the patch to fix that. Please review it.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-06-21 20:36:35 pgAdmin 4 commit: Allow dropping of Procedures in PG 11. Fixes #3423
Previous Message Dave Page 2018-06-21 20:34:56 pgAdmin 4 commit: Minor fix to handle auto-discovery of servers with no