Re: Require suggestions for Issue #2874

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Rohit Bhati <rohit(dot)bhati(at)enterprisedb(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Require suggestions for Issue #2874
Date: 2024-09-05 11:32:48
Message-ID: CA+OCxoxOzUKjPF8pC=z4vjVKegBzNUDtGtwc5tewmtz2MfMhMw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Thu, 5 Sept 2024 at 12:19, Rohit Bhati <rohit(dot)bhati(at)enterprisedb(dot)com>
wrote:

> Hi,
>
> Currently it is just theme based, whenever the user changes the theme
> accordingly the color changes.
> Not for any specific preference option for this right now, But if we want
> that we can add.
>

Let's just go with it for now, and if people don't like it, we can add a
preference.

>
> And if i am not wrong you are talking about this #7863
> <https://github.com/pgadmin-org/pgadmin4/issues/7863> . If this is the
> issue then I can work together on both.
>

Yes, that's the one :-)

>
>
> Rohit Bhati
> EnterpriseDB
>
> On Thu, Sep 5, 2024 at 3:51 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thu, 5 Sept 2024 at 08:27, Rohit Bhati <rohit(dot)bhati(at)enterprisedb(dot)com>
>> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please check the updated attached screenshot for an alternate
>>> background color of table rows.
>>> The images also shows alternate row color with some selected rows color
>>> from the table.
>>>
>>>
>> I think that looks good. Are you making it a preference, so users that
>> prefer non-stripey grids can keep the current look?
>>
>> Whilst you're hacking on that, I believe there is another ticket (which I
>> can't find right now) about changing the colour of the row number column to
>> give it better visual distinction from the data columns. Probably worth
>> working on that one at the same time?
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>
>>

--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com

PGDay UK 2024, 11th September, London: https://2024.pgday.uk/

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Rohit Bhati 2024-09-05 13:38:20 Re: Require suggestions for Issue #2874
Previous Message Rohit Bhati 2024-09-05 11:19:03 Re: Require suggestions for Issue #2874