From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Fix for RM2811 |
Date: | 2017-11-27 11:58:10 |
Message-ID: | CA+OCxoxORVgzgvSLosDPso2xOQGkm8GfEnUkjs0ea8Hv5JgA0Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Mon, Nov 27, 2017 at 11:23 AM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find attached patch to fix RM2811
>
> Issue was caused due to assumption made when current position in log file
> while reading it reaches to last line then
> we were assuming process is finished. However this is not the case.
> Background process may be busy performing
> some other task and logs might not be logged to file immediately. So we
> should also check process exit code along
> with above condition.
>
> Apart from above this patch also includes minor fix related to status text
> colour.
>
Seems to work nicely, except that the text scrolls out of view almost
immediately. Can you fix it to jump to the end of the text when more is
appended please?
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-11-27 12:01:54 | pgAdmin 4 commit: Use sufficiently long random strings in test objects |
Previous Message | Dave Page | 2017-11-27 11:54:02 | Re: [pgAdmin4][Patch]: To decode database errors properly |