Re: Require suggestions for Issue #2874

On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <rohit(dot)bhati(at)enterprisedb(dot)com>
wrote:

> I have made some more changes with changing background color.
>

Yeah, that looks weird again, specifically on the selected rows. I believe
the issue is that we should not highlight the row number column when a row
is selected at all. That makes sense, as we should only be highlighting the
columns that would get copied in a copy/paste operation anyway.

Also, the bold still doesn't look bold. I think the weight needs to be
increased.

>
> I have attached screenshots showing how the updates look across all themes
> .
>
> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <rohit(dot)bhati(at)enterprisedb(dot)com>
>> wrote:
>>
>>> Hi,
>>>
>>> I have removed the border and background color, just made the row
>>> numbers bold.
>>>
>>> I have attached screenshots showing how the updates look across all
>>> themes.
>>>
>>
>> That doesn't look bold at all to me - and I think we still need some
>> other visual distinction, such as the column background colour.
>>
>>
>>>
>>>
>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>>
>>>>
>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>> rohit(dot)bhati(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I have made changes for issue #7863
>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863> based on theme
>>>>>> requirements.
>>>>>>
>>>>>> I have attached screenshots showing how the updates look across all
>>>>>> themes for your reference.
>>>>>>
>>>>>> If the current color does not fit well with the theme or if you have
>>>>>> any suggestions for improvements, please let me know.
>>>>>>
>>>>>
>>>>> Is the colour contrast high enough on the row numbers for selected
>>>>> rows in the high contrast theme? The black on grey seems like it might not
>>>>> be to me, but I haven't tested.
>>>>>
>>>>> I wonder also if we should make the row numbers bold all the time.
>>>>> Thoughts?
>>>>>
>>>> We can check how it looks. Also the cell border doesn't look good to me.
>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> pgAdmin: https://www.pgadmin.org
>>>>> PostgreSQL: https://www.postgresql.org
>>>>> EDB: https://www.enterprisedb.com
>>>>>
>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>
>>>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>
>>

--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com

PGDay UK 2024, 11th September, London: https://2024.pgday.uk/