Re: Module-wise Keyboard preferences

On Tue, Jan 23, 2018 at 10:36 AM, Shirley Wang <swang(at)pivotal(dot)io> wrote:

> Oh interesting. Was there a particular reason why they wanted it
> configurable?
>

To make it match other tools they already use. As we've discussed in the
past, there are semi-defacto standards for many shortcuts across common
tools, but there are variations.

>
> On Tue, Jan 23, 2018 at 6:24 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> On Tue, Jan 23, 2018 at 10:20 AM, Shirley Wang <swang(at)pivotal(dot)io> wrote:
>>
>>> It would be easier for users if we determined the best shortcut for
>>> these are and then list them rather than give people options.
>>>
>>
>> For the defaults, we will (where possible). The problem is that we're
>> extremely limited in what we can use as there's too much conflict between
>> browsers.
>>
>> Not to mention that users have asked us to make this configurable a
>> number of times.
>>
>>
>>>
>>> For example:
>>> [image: Screen Shot 2018-01-23 at 6.18.21 PM.png]
>>>
>>> On Tue, Jan 23, 2018 at 2:31 PM Harshal Dhumal <
>>> harshaldhumal15(at)gmail(dot)com> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> On Mon, Jan 22, 2018 at 5:26 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Fri, Jan 19, 2018 at 9:29 AM, Harshal Dhumal <
>>>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> On Wed, Jan 17, 2018 at 4:58 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> To summarise an offline discussion we just had, the intention is to
>>>>>>> replace the switches with checkboxes for Shift, Control, and Alt/Option,
>>>>>>> then to try to come up with a set of default shortcuts that work on the
>>>>>>> major platforms/browsers. Investigation into Javascript's handling of
>>>>>>> keycodes vs. strings is ongoing to figure out the best way to capture and
>>>>>>> display the selected keys for non-ASCII locales (String.fromCharCode()).
>>>>>>>
>>>>>>
>>>>>> I have replaced switches with checkboxes and also showing all
>>>>>> controls for one preference in single line.
>>>>>>
>>>>>> [image: Screen Shot 2018-01-19 at 2.27.51 pm.png]
>>>>>>
>>>>>
>>>>> I'm still not happy with the way that looks. Wrapping "Alt/Option"
>>>>> looks horrible - plus it also looks a little odd that labels are closer to
>>>>> the preceding controls than to the following controls to which they
>>>>> actually apply.
>>>>>
>>>>>
>>>>>> Regarding String.fromCharCode() to reverse map keycode to char
>>>>>> (actual char on keyboard) does not work for all keyboard keys.
>>>>>>
>>>>>> For eg. on mac with standard keyboard and with my locale settings I
>>>>>> got below behaviour.
>>>>>> For key tilde (~) I got keycode 192 (Unicode value of the pressed
>>>>>> keyboard key as per docs) and
>>>>>> when I tried to map 192 (String.fromCharCode(192)) to get actual
>>>>>> char, I got À <http://www.codetable.net/decimal/192>
>>>>>>
>>>>>> So instead of mapping keycode to char for display purposse I'm using
>>>>>> char which is returned by event object
>>>>>>
>>>>>
>>>>> OK, sounds fine.
>>>>>
>>>>> Regarding the patch:
>>>>>
>>>>> - It's missing doc updates
>>>>>
>>>> My patch is related to add infrastructure for keyboard shortcut
>>>> preferences and not to add any particular preference.
>>>> We can add docs for actual keyboard preference when we start adding
>>>> keyboard preferences.
>>>>
>>>> I share two patches out of one is example (keyboard shortcut
>>>> preferences for debugger) and not a final patch.
>>>> It's purpose is provide example (for developers only) about how to add
>>>> keyboard preferences.
>>>>
>>>> Please let me know which doc updates are you expecting?
>>>>
>>>>
>>>>
>>>>> - There's a huge chunk of JS in there. Can that be split up into
>>>>> smaller chunks and unit tests created for them?
>>>>>
>>>>> Thanks.
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company