Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)
Date: 2016-06-22 08:05:44
Message-ID: CA+OCxoxKUd6eFGeCsb9Q0v6xfjEPSvBPMwxwp882KHyG35cx1g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Jun 22, 2016 at 7:14 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix the issue in server port check constraint validation which
> was not allowing user to save port 65535. (RM#1388)
>
> We have changed in server table definition hence user has to run "setup.py"
> again to fix the issue.

Hmm, I think we need to extend pgAdmin4.py to do that upgrade
automatically, in the same way that it will automatically run setup if
the database doesn't exist. Can we add a version check there, and
upgrade if needed?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-06-22 08:32:14 PATCH: Do not allow to drop current maintenance DB
Previous Message Murtuza Zabuawala 2016-06-22 06:14:36 PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)