Re: RM 6427 - Newlines in text columns of resultset show an allegedly "empty" field

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
Subject: Re: RM 6427 - Newlines in text columns of resultset show an allegedly "empty" field
Date: 2021-07-01 08:18:34
Message-ID: CA+OCxoxKLYhikMGLUVVW=EVMQ_8dEKLv24r=HoXGmaaqgjvaHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, committed.

On Wed, Jun 30, 2021 at 1:11 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Wed, Jun 30, 2021 at 12:36 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> On Wed, Jun 30, 2021 at 3:35 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Here's a simple patch for $SUBJECT. It will remove any leading spaces
>>> from the grid cell display and replace them with '[...] '. In edit mode,
>>> the data is unchanged.
>>>
>>> The patch looks good to me.
>>
>
> Thanks.
>
>
>> Do we need to specify somewhere what is [...] ?
>>
>
> I don't think there's much point.
>
>
>>
>> The only downside I can see to this is that the tooltip will show the
>>> modified data when it probably should actually show the un-modified data.
>>> Unfortunately that's handled by a SlickGrid plugin, which would have to be
>>> vendorised and modified (perhaps non-trivially). I don't think that's a big
>>> issue though.
>>>
>>> --
>>> Dave Page
>>> Blog: https://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EDB: https://www.enterprisedb.com
>>>
>>>
>
> --
> Dave Page
> Blog: https://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: https://www.enterprisedb.com
>
>

--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2021-07-01 12:41:02 pgAdmin 4 commit: Highlighted long running queries on the dashboards. F
Previous Message Dave Page 2021-07-01 08:17:38 pgAdmin 4 commit: Remove leading whitespace and replace it with '[...]