Re: Windows build system cleanup

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Windows build system cleanup
Date: 2020-06-01 08:57:30
Message-ID: CA+OCxoxHm2DQewFbhcVH+6FLK6Mut7NkRdgKwrhQQ8geTUOL8Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - committed. I've updated the Jenkins jobs that run Make.bat with
the new variable names. I'll keep an eye out for any failures and fix
anything that pops up. Once it's stable I'll remove all the old variables.

On Mon, Jun 1, 2020 at 8:53 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Dave
>
> Patch looks good to me, did eyeball review.
>
> On Fri, May 29, 2020 at 1:43 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Stupid line endings confusing git :-(. Here's another attempt.
>>
>> On Fri, May 29, 2020 at 7:30 AM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave
>>>
>>> Unable to apply the patch. Can you please rebase and send it again.
>>>
>>> On Thu, May 28, 2020 at 9:04 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Here's a patch to cleanup the windows build system and make sure 64 bit
>>>> builds work with modern tools. It also updates the README with a new
>>>> from-scratch setup process that makes it much easier to setup a Windows
>>>> build/dev machine.
>>>>
>>>> Please review, but don't apply as I'll need to do that in conjunction
>>>> with some Jenkins changes.
>>>>
>>>> Note that I haven't tested a 32 bit build as I don't have a working
>>>> environment for that to hand and don't really want to spend time setting
>>>> one up before we deprecate it. I'll fix any issues that show up in Jenkins.
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2020-06-01 09:31:39 pgAdmin 4 commit: Ignore venv directories in the tree.
Previous Message Dave Page 2020-06-01 08:52:26 pgAdmin 4 commit: Cleanup Windows build scripts and ensure Windows x64