Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ganesh Jaybhay <ganesh(dot)jaybhay(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control
Date: 2019-07-09 15:58:41
Message-ID: CA+OCxoxHi6PU7dTbC1qvswniaCsrGmhkfaRYO_jimX14xg3zhQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

What's the ticket number for this? That's a fair amount of code for a
one-line description. There are also no doc changes describing how to
navigate the sub-node control that I can see.

Also; instead of changing the repo used for backgrid, can we not
un-vendorise it?

On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay <
ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch for keyboard accessibility of sub-node control. It
> also covers sub-node dialog forward/backward tab navigation with shortcuts.
>
> Kindly review.
>
> Regards,
> Ganesh Jaybhay
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-07-09 16:03:00 pgAdmin 4 commit: Add Reverse Engineered SQL tests for FTS Configuratio
Previous Message Dave Page 2019-07-09 13:14:49 pgAdmin 4 commit: Add an example Traefik configuration.