Re: [pgAdmin4][Patch]: RM #4362 trigger function create script

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #4362 trigger function create script
Date: 2019-06-19 14:27:46
Message-ID: CA+OCxoxFsPN_vP3k6znphGTm7t0L3Ov3ScVhO6hsEMQztN_RDQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Wed, Jun 19, 2019 at 9:55 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Hackers,
>
> Attached is the patch to fix RM #4362 trigger function create script.
> Please review it.
>

While I can see how this works, I question why we have the string "SETOF"
in prorettypname anyway? That's a separate property, so it should be in a
separate variable. What if I have a type called "SETOFDavesStuff"
(unlikely, but it illustrates the point)?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-06-19 15:17:01 Re: [pgAdmin4][Patch]: RM #4362 trigger function create script
Previous Message Dave Page 2019-06-19 14:10:51 Re: [GSoC][Patch] Automatic Mode Detection V1