Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure
Date: 2021-06-28 16:03:28
Message-ID: CA+OCxoxE+OK3_KW_vu_pWY4+t5qyH985_Znp7v+uA2vmYRo2BQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat <
rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Please find the attached patch for fixation of jenkins failure.
>

That won't work - you can't include variables (or string building
operations) in the first argument to gettext calls, as there won't be any
way to extract a complete message into the catalogs. The way it's being
done at the moment is correct (I don't know why it's failing, but it's the
correct way to structure the gettext calls).

--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Rahul Shirsat 2021-06-29 03:38:13 Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure
Previous Message Rahul Shirsat 2021-06-28 15:56:18 [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure