Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection
Date: 2016-09-15 08:08:19
Message-ID: CA+OCxoxDWXefwTOWHhLkXJ7BK=CajDhEMkuwzWzUxVBR_ResLQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

(pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM1579.patch
error: patch failed: web/pgadmin/static/css/overrides.css:53
error: web/pgadmin/static/css/overrides.css: patch does not apply

Please rebase!

On Thu, Sep 15, 2016 at 8:54 AM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> Please find the attached patch patch with following changes:
>
> 1) Implemented CodeMirror addon 'simplescrollbars'.
>
> 2) The CodeMirror instance of query tool was not rendering into wcDocker's
> 'pg-panel-content' div. it renders outside the div, due to which it took
> little more time investigating why scrollbars doesn't appear in editor.
>
> 3) Add new css specific to query tool.
>
>
> Please review.
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2016-09-15 09:04:07 Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection
Previous Message Ashesh Vashi 2016-09-15 08:08:06 pgAdmin 4 commit: The Switch Dependency Cell, implemented in schema mod