Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4)

Hi

On Thu, Jul 28, 2016 at 10:56 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> PFA updated patch to fix issue in functions which was due to improper
> handing of nested quoting of types in templates.
> I also fixed it in Table/Column node.
>
> Please review.

This doesn't seem right to me:

# If schema is not pg_catalog & then add schema
if row['nspname'] != 'pg_catalog' \
and row['nspname'] == 'public':
rtn_type = row['nspname'] + "." + row['typname']
else:
rtn_type = row['typname']

Shouldn't the "and row['nspname'] == 'public'" be removed?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company