Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in Sqleditor module

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in Sqleditor module
Date: 2017-06-26 11:43:17
Message-ID: CA+OCxoxApyvKSyAbcFXgy0vbM1Ks_4DAUDK5a-wWRZdYb5C2MQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Mon, Jun 26, 2017 at 2:45 AM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> Changes:
>
> 1. Replace Jinja {{ url_for }} with js 'url_for'
>
> 2. While minifying JS using webpack, I got couple of errors(variables
> undefined) in browser for generated sqleditor.js, so declared those
> variables before using them.
>
> Please find attached patch.
>
> Thanks,
> Surinder Kumar

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-06-26 11:43:32 Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in the datagrid module
Previous Message Dave Page 2017-06-26 11:38:03 Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed