Re: pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.
Date: 2017-08-25 15:00:33
Message-ID: CA+OCxox9b27Dj1m_6JPKk5GSw=2oSoP-4BXjB+z_uqcgxzC=RA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

I believe this patch has broken my installation. When I try to run now, I
get:

Exception in thread Thread-1:
Traceback (most recent call last):
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 810, in __bootstrap_inner
self.run()
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 763, in run
self.__target(*self.__args, **self.__kwargs)
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 602, in process_request_thread
self.handle_error(request, client_address)
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 599, in process_request_thread
self.finish_request(request, client_address)
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 334, in finish_request
self.RequestHandlerClass(request, client_address, self)
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 655, in __init__
self.handle()
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 200, in handle
rv = BaseHTTPRequestHandler.handle(self)
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/BaseHTTPServer.py",
line 340, in handle
self.handle_one_request()
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 235, in handle_one_request
return self.run_wsgi()
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 177, in run_wsgi
execute(self.server.app)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 165, in execute
application_iter = app(environ, start_response)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 2000, in __call__
return self.wsgi_app(environ, start_response)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1988, in wsgi_app
response = self.full_dispatch_request()
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1634, in full_dispatch_request
self.try_trigger_before_first_request_functions()
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1660, in try_trigger_before_first_request_functions
func()
File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/__init__.py", line 43,
in create_module_preference
self.register_preferences()
File
"/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
line 172, in register_preferences
ServerType.register_preferences()
File
"/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/types.py",
line 57, in register_preferences
default_path = config.DEFAULT_BINARY_PATHS[st.stype] or ""
KeyError: 'gpdb'

On Fri, Aug 25, 2017 at 1:25 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Greenplum specific DDL and Dashboard display changes.
> Initial patch by Sarah McAlear<smcalear(at)pivotal(dot)io>.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 46c5df4e7bb7abba6896cfb86eed43914a74850a
> Author: Teng Zhang <tezhang(at)pivotal(dot)io>
>
> Modified Files
> --------------
> web/config.py | 3 +-
> .../templates/table/sql/gpdb_5.0_plus/create.sql | 168
> +++++++++++++++++++++
> .../table/sql/gpdb_5.0_plus/properties.sql | 82 ++++++++++
> .../servers/databases/schemas/tables/utils.py | 7 +-
> web/pgadmin/browser/server_groups/servers/gpdb.py | 20 +++
> web/pgadmin/dashboard/__init__.py | 7 +-
> .../dashboard/sql/gpdb_5.0_plus/activity.sql | 14 ++
> .../dashboard/sql/gpdb_5.0_plus/locks.sql | 22 +++
> .../dashboard/sql/gpdb_5.0_plus/session_stats.sql | 4 +
> .../gpdb_5.0_plus/some_action_with_gpdb_5_0.sql | 1 +
> .../utils/tests/test_versioned_template_loader.py | 36 ++++-
> web/pgadmin/utils/versioned_template_loader.py | 39 +++--
> 12 files changed, 385 insertions(+), 18 deletions(-)
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2017-08-25 15:41:15 Re: pgAdmin 4 commit: Fix the feature tests failuers.
Previous Message Dave Page 2017-08-25 14:56:42 Re: pgAdmin 4 commit: Fix the feature tests failuers.